Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(general): Add coverage upload #57

Merged
merged 16 commits into from
Oct 11, 2024
Merged

ci(general): Add coverage upload #57

merged 16 commits into from
Oct 11, 2024

Conversation

oldGreg5
Copy link
Contributor

@oldGreg5 oldGreg5 commented Oct 10, 2024 •
edited
Loading

Description

Add test coverage for catalyst libs repo

Related Issue(s)

Resolves #840

Description of Changes

Add saving coverage results and uploading to Coveralls here

Breaking Changes

Screenshots

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@oldGreg5 oldGreg5 linked an issue Oct 10, 2024 that may be closed by this pull request
🛠️ [TASK] : Add test coverage for catalyst libs repo input-output-hk/catalyst-voices#840
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

✅ Test Report | ${\color{lightgreen}Pass: 202/202}$ | ${\color{red}Fail: 0/202}$ |

@oldGreg5 oldGreg5 changed the title add coverage upload ci(general): Add coverage upload Oct 11, 2024
@oldGreg5 oldGreg5 marked this pull request as ready for review October 11, 2024 10:36
@oldGreg5 oldGreg5 added the review me PR is ready for review label Oct 11, 2024
@oldGreg5 oldGreg5 self-assigned this Oct 11, 2024
@oldGreg5 oldGreg5 requested a review from kukkok3 October 11, 2024 10:52
@minikin minikin enabled auto-merge (squash) October 11, 2024 11:16
kukkok3
kukkok3 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin merged commit 430de06 into main Oct 11, 2024
22 checks passed
@minikin minikin deleted the 840-task-add-test-coverage-for-catalyst-libs-repo-1 branch October 11, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukkok3 kukkok3 kukkok3 approved these changes

Assignees

@oldGreg5 oldGreg5

Labels
review me PR is ready for review
Projects
Catalyst
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Add test coverage for catalyst libs repo
3 participants
@oldGreg5 @kukkok3 @minikin